Closed Trade shop improvements

Discussion in 'Server Gameplay Suggestions Archive' started by _SaikiK_, May 13, 2020.

  1. _SaikiK_
    Offline

    _SaikiK_ Active Member

    Joined:
    Aug 21, 2018
    Messages:
    62
    Sorry I can't write much because I'm in a rush, here the suggestions:
    1) If there is only one item in the chest, the shop should default to it instead of the player having to take it out, hit the sign with and and put it back in
    2) I would like the ability to add a friend to my shop (like normal lockette) so they can refill it for me.
     
    • No Support No Support x 3
    • Neutral Neutral x 2
  2. Pillow
    Offline

    Pillow blanky Premium

    Joined:
    May 27, 2019
    Messages:
    1,981
    IGN:
    Pilberry
    I support 2 but not 1 and the plugin is not custom made so can't really be modified easily.
     
  3. _SaikiK_
    Offline

    _SaikiK_ Active Member

    Joined:
    Aug 21, 2018
    Messages:
    62
    It doesn't really make sense you support 2 but not 1 because they would require the same plugin to be modified.
     
  4. Splat1221
    Offline

    Splat1221 Active Member

    Joined:
    Jun 23, 2018
    Messages:
    962
    IGN:
    SplatBerry
    2 support fully
     
  5. boba
    Offline

    boba Discord Moderator Discord Moderator Premium

    Joined:
    Dec 26, 2019
    Messages:
    2,349
    Support,

    It would be nice if the chest automatically detects the block and makes the chestshop instead of the player to click the sign with the blocks. Number 2 is also good. Having another person have access to the shops so refill is easy.
     
  6. Pillow
    Offline

    Pillow blanky Premium

    Joined:
    May 27, 2019
    Messages:
    1,981
    IGN:
    Pilberry
    Yes, but I support one idea and not the other - I can choose one if I want.
     
  7. _SaikiK_
    Offline

    _SaikiK_ Active Member

    Joined:
    Aug 21, 2018
    Messages:
    62
    You first said you don't sopport 2 because it's hard to do, I say 1 is not easier and now you just say "I can choose what I want"?
     
  8. Pillow
    Offline

    Pillow blanky Premium

    Joined:
    May 27, 2019
    Messages:
    1,981
    IGN:
    Pilberry
    It doesn't matter. It's just the plugin isn't custom so can't be easily modified. RedstoneTrails am I correct in saying it's custom made?
     
  9. WhatsUpDoc
    Offline

    WhatsUpDoc Eh What's Up Doc? Premium

    Joined:
    Apr 28, 2019
    Messages:
    559
    IGN:
    WhatsUpDoc
    personally I don't see much of a problem here, also you could have many items in the chest making this useless anyways and kind of annoying, the friend part is somewhat nessacary, but a super mod can always break the chest for you if you're friend quit ect. implementing that into the tradeshop would be way to hard when the devs already have 2000 things to do and still have lives.
     
  10. PCcoolguy100
    Offline

    PCcoolguy100 Senior Member

    Joined:
    Apr 4, 2015
    Messages:
    1,408
    IGN:
    PCcoolguy100
    2 has already been suggested, 1 I'd say no.

    I like the current system of smacking the tradeshop.
     
  11. _SaikiK_
    Offline

    _SaikiK_ Active Member

    Joined:
    Aug 21, 2018
    Messages:
    62
    I can understand that the team might have better thinks to do but the Suggestions Forum exists for a reason.
     
  12. WhatsUpDoc
    Offline

    WhatsUpDoc Eh What's Up Doc? Premium

    Joined:
    Apr 28, 2019
    Messages:
    559
    IGN:
    WhatsUpDoc
    I agree, I’m just stating what I think, not trying to attack you :)
     
  13. _SaikiK_
    Offline

    _SaikiK_ Active Member

    Joined:
    Aug 21, 2018
    Messages:
    62
    I didnt want to be harsh either but in this Suggestions Forum the argument against it it always something like "devs have better things to do" or "it's too much effort"
     
  14. GAMER1232012
    Offline

    GAMER1232012 Experienced Member

    Joined:
    Nov 11, 2014
    Messages:
    907
    Is it really too much to ask to open a chest and slap it with an item? I agree it's annoying but it takes about 3 seconds maximum. Even if you had to do this twenty times a week, it'd only cost you a minute total.
     
  15. _SaikiK_
    Offline

    _SaikiK_ Active Member

    Joined:
    Aug 21, 2018
    Messages:
    62
    Yes and no. There are basically workarounds for every suggestion on here. It shouldn't be that much effort to put it in and all players will benefit from it.
     
  16. RedstoneTrails
    Offline

    RedstoneTrails Moderator Moderator

    Joined:
    Aug 4, 2014
    Messages:
    484
    IGN:
    RedstoneTrails
    Shop plugin is custom made, at least for our Skyblock Survival server.

    As for the suggestion, 2 has been suggested a good bit, and I'm always in favor of it. As a workaround, you can have trusted/coop'd people place items inside of the chest using a hopper, or you can message LeoSteel about a little workaround to allow multiple people to access a trade shop.

    1 would become a bit of a mess, and potentially open the door for more performance issues. We'd have to start checking every trade shop on the server, see what's inside of it, and then do work based off of what's inside.
     
  17. _SaikiK_
    Offline

    _SaikiK_ Active Member

    Joined:
    Aug 21, 2018
    Messages:
    62
    I don't know how your server internals are working but this really shouldn't be neccessary. Why would you check every single chest if you just need to check the one to sign is connected to (I'm certain the plugin already does that.). Then just do
    Code:
    ItemStack[] contents = ((Chest) block.getState()).getInventory().getContents();
    if(contents.length == 1) {
        Material item = contents[0].getMaterial();
        setItem(item); // replace this with the correct function.
    }
    Even easier than doing 2. Thank me later.
     
  18. Tog
    Offline

    Tog atpoaim Premium Premium Premium Premium

    Joined:
    May 8, 2018
    Messages:
    1,654
    IGN:
    Togpuss
    I do support suggestion 2 but suggestion 1 for me is a big no no. I guess that leaves me Neutral.
     
  19. Flamedestroyer44
    Offline

    Flamedestroyer44 Member

    Joined:
    Oct 14, 2018
    Messages:
    65
    I support suggestion 2, it would be really great if two people could share the profit from a shop.
     
  20. _SaikiK_
    Offline

    _SaikiK_ Active Member

    Joined:
    Aug 21, 2018
    Messages:
    62
    Seems like most people are against 1, but can you please explain why it's a "big no no" for you?
     

Share This Page